After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792278 - Remove HAVE_LOCALE_H checks
Remove HAVE_LOCALE_H checks
Product: gnome-keyring
Classification: Core
Component: general
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Reported: 2018-01-06 18:35 UTC by Ting-Wei Lan
Modified: 2018-01-07 06:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

main: Remove unnecessary HAVE_LOCALE_H checks (1.07 KB, patch)
2018-01-06 18:38 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2018-01-06 18:35:24 UTC
I cannot find HAVE_LOCALE_H in config.h, and gnome-keyring already includes locale.h unconditionally. Can we simply remove the checks? Both locale.h and setlocale are in the standard C.

If setlocale is not called before using gettext, running 'gnome-keyring-daemon --help' on FreeBSD with zh_TW.UTF-8 will show broken help messages:

  gnome-keyring-daemon [???] - The Gnome Keyring Daemon

  -h, --help                              ???????

  -s, --start                             Start a dameon or initialize an already running daemon.
  -r, --replace                           Replace the daemon for this desktop login environment.
  -f, --foreground                        Run in the foreground
  -d, --daemonize                         Run as a daemon
  -l, --login                             Run by PAM for a user login. Read login password from stdin
  --unlock                                Prompt for login keyring password, or read from stdin
  -c, --components=pkcs11,secrets,ssh     The optional components to run
  -C, --control-directory                 The directory for sockets and control data
  -V, --version                           Show the version number and exit.
Comment 1 Ting-Wei Lan 2018-01-06 18:38:23 UTC
Created attachment 366427 [details] [review]
main: Remove unnecessary HAVE_LOCALE_H checks
Comment 2 Daiki Ueno 2018-01-06 20:12:46 UTC
Review of attachment 366427 [details] [review]:

Thanks, looks fine.
Comment 3 Ting-Wei Lan 2018-01-07 06:52:40 UTC
Attachment 366427 [details] pushed as 2df1366 - main: Remove unnecessary HAVE_LOCALE_H checks