After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792264 - style: Fix details-license-nonfree button css
style: Fix details-license-nonfree button css
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-01-06 07:53 UTC by Mohammed Sadiq
Modified: 2018-01-08 10:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
style: Fix details-license-nonfree button css (944 bytes, patch)
2018-01-06 07:53 UTC, Mohammed Sadiq 		none Details | Review

Description Mohammed Sadiq 2018-01-06 07:53:45 UTC 
This was shown when opening gimp application. I hope that
the gimp being marked as non-free is a bug in packagekit.
Comment 1 Mohammed Sadiq 2018-01-06 07:53:52 UTC 
Created attachment 366409 [details] [review]
style: Fix details-license-nonfree button css

The details-license-nonfree button css once set was overridden
again later.

This resulted in white text on light background on hover and
white border on focus out.

Let it be fixed by just removing the overridden css.
Comment 2 Kalev Lember 2018-01-08 10:27:14 UTC 
Thanks Mohammed! I don't think the fix is fully correct, but you were definitely on the right track here. The duplicated second css was actually meant for the "nonfree" style. I've fixed that here:

https://git.gnome.org/browse/gnome-software/commit/?id=516f77b7d04f0160b81136bcdbc6ec3ebe3a5f15