After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792263 - dashdemux: do not parse mpd file and setup streams if updated mpd file is not changed at all
dashdemux: do not parse mpd file and setup streams if updated mpd file is not...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-06 05:54 UTC by Jun Xie
Modified: 2018-11-03 14:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
do not parse mpd file and setup streams if updated mpd file is not changed at all (2.98 KB, patch)
2018-01-06 05:59 UTC, Jun Xie
none Details | Review

Description Jun Xie 2018-01-06 05:54:05 UTC
if updated mpd file is the same with last one, not changed at all, then no bother to parse mpd file and setup streams.
Comment 1 Jun Xie 2018-01-06 05:59:12 UTC
Created attachment 366407 [details] [review]
do not parse mpd file and setup streams if updated mpd file is not changed at all
Comment 2 Jun Xie 2018-01-16 07:38:48 UTC
please review :)
Comment 3 sraut 2018-02-03 17:54:58 UTC
Hi Jun, 

I am trying to understand the changes that you made. Is there any particular stream that you used? If so can you please provide the link or should use any one stream from https://github.com/Dash-Industry-Forum/dash-live-source-simulator/wiki/Test-URLs?
Comment 4 Jun Xie 2018-02-05 06:56:14 UTC
hi sraut,

basically, it is handling with $Number$-template type,
like http://vm2.dashif.org/livesim/testpic_2s/Manifest.mpd.

But unlike the above one, some content provider set 'minimumUpdatePeriod' a short period,
but actually the mpd file is not changed at all.

Currently, each updated mpd file will be parsed and stream are set up again, event nothing changed at all.
The patch is trying to deal with such scenario.
Comment 5 sraut 2018-02-05 14:50:13 UTC
Hi Jun,

Thanks for the explanation. I am able to change the 'minimumUpdatePeriod' to 2 seconds by changing the above mpd URL to: http://vm2.dashif.org/livesim/mup_2/testpic_2s/Manifest.mpd (adding mup_x before /testpic_2s).

However, couldn't find the following line: "Updated mpd is not changed at all, do nothing" in the logs. 

Can you please let me know what value should 'minimumUpdatePeriod' have in order to see the changes?

Thanks
Comment 6 Jun Xie 2018-02-06 01:53:15 UTC
hi sraut,

the mpd's 'publishTime' is changed, so while doing memcmp, it is judged as changed.

Content provider has different behaviors.
This patch can cover $Number$-template type with not thing changed at all.
I do not remember which stream generator vendor has such behavior, but we do have met a lot:)
Comment 7 sraut 2018-02-06 09:41:50 UTC
Hi Jun,
Got it. Thanks.
Comment 8 GStreamer system administrator 2018-11-03 14:17:17 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/647.