After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792256 - Remove ellipsis from prefs menu entries
Remove ellipsis from prefs menu entries
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-05 22:13 UTC by Egmont Koblinger
Modified: 2018-01-06 10:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Egmont Koblinger 2018-01-05 22:13:45 UTC
Currently we have

Edit -> Preferences…
Edit -> Profile Preferences…
right click -> Profiles -> Profile Preferences…

https://developer.gnome.org/hig/stable/writing-style.html.en says:

Do not add an ellipsis to labels such as Properties or Preferences. While these commands open windows that can incorporate further functionality, the label does not specify an action, and therefore does not need to communicate that further input or confirmation is required.
Comment 1 Egmont Koblinger 2018-01-05 22:49:35 UTC
These appeared with the GMenu port. We should quickly remove them to save work for translators.

What about "New Profile", does that deserve the ellipsis? I guess so.
Comment 2 Christian Persch 2018-01-05 23:22:09 UTC
I didn't specifically decide to add the … with the gmenu port, so it's fine to remove them where contradicted by the style guide.

New Profile has a bit more of a 'more input required' feel than Profile Preferences on an existing profile, so might keep the ….
Comment 3 Egmont Koblinger 2018-01-05 23:34:18 UTC
I'm not too worried about "New Profile" since I'm hoping to remove that with the prefs merge for 3.30. We could remove the ellipsis here which would be translator-friendly (the pre-GMenu version), or keep them which would probably be the more correct, henece user-friendly. Let's choose user-friendly. :)
Comment 4 Christian Persch 2018-01-05 23:39:03 UTC
Saving l10ners time is good, so let's use the pre-gmenu version.
Comment 5 Egmont Koblinger 2018-01-06 10:22:11 UTC
Okay.

Fixed.