After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792207 - [3.27.3] gnome.desktop not installed to wayland-sessions
[3.27.3] gnome.desktop not installed to wayland-sessions
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-04 14:43 UTC by Dominique Leuenberger
Modified: 2018-01-08 21:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meson: unconditionally copy session file (1.89 KB, patch)
2018-01-08 21:54 UTC, Ray Strode [halfline]
committed Details | Review

Description Dominique Leuenberger 2018-01-04 14:43:20 UTC
gnome.desktop is not being install to $DESTDIR/usr/share/wayland-sessions when $DESTDIR is defined.

meson.build can't do it, as meson does not yet support copying the same file to multiple targets

# FIXME: The same target can not be copied into two directories.
#        There is a workaround in meson_post_install.py until proper solution arises:
#        https://groups.google.com/forum/#!topic/mesonbuild/3iIoYPrN4P0


and meson_post_install.py does not do it when DESTDIR is defined:

if not os.environ.get('DESTDIR'):
[…]
  # FIXME: this is due to unable to copy a generated target file:
  #        https://groups.google.com/forum/#!topic/mesonbuild/3iIoYPrN4P0
  dst_dir = os.path.join(sys.argv[1], 'wayland-sessions')
  if not os.path.exists(dst_dir):
    os.makedirs(dst_dir)
Comment 1 Ray Strode [halfline] 2018-01-08 21:54:21 UTC
Created attachment 366521 [details] [review]
meson: unconditionally copy session file

gnome.desktop is installed in two places, but only if
DESTDIR is unset..

This commit makes it always happen.
Comment 2 Ray Strode [halfline] 2018-01-08 21:54:58 UTC
Attachment 366521 [details] pushed as 9b37ffc - meson: unconditionally copy session file