After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792201 - Move match-names test from Tracker backend tests to general tests
Move match-names test from Tracker backend tests to general tests
Status: RESOLVED OBSOLETE
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2018-01-04 13:08 UTC by Niels De Graef
Modified: 2018-09-21 16:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[Patch] Tests: move match-names to dummy backend tests (4.26 KB, patch)
2018-01-06 15:40 UTC, Niels De Graef 		needs-work Details | Review

Description Niels De Graef 2018-01-04 13:08:40 UTC 
In light of bug 79216: move the match-names test out of the Tracker backend to the list of general tests.
Comment 1 Philip Withnall 2018-01-05 12:33:47 UTC 
(In reply to Niels De Graef from comment #0)
> In light of bug 79216: move the match-names test out of the Tracker backend
> to the list of general tests.

(That should be bug #792196.)
Comment 2 Niels De Graef 2018-01-06 15:40:56 UTC 
Created attachment 366424 [details] [review]
[Patch] Tests: move match-names to dummy backend tests

In the end it wasn't too hard to change it, but it seems that one of the assertions is failing, so I'll take a look at it once I'm on a break again.
Comment 3 Philip Withnall 2018-01-08 11:04:03 UTC 
Review of attachment 366424 [details] [review]:

Thanks, although it needs a little bit more work.

Could you do a follow-up patch to add new tests which check for regressions in the bugs you fixed recently? And which also check other situations around length handling for the match code?

::: tests/tracker/match-name.vala
@@ -198,3 @@
-      if (this._pstore.is_prepared && this._added_personas == false)
-        {
-          this._added_personas = true;

The `_added_personas` member is now unused and can be removed.
Comment 4 GNOME Infrastructure Team 2018-09-21 16:10:35 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/folks/issues/98.