After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792198 - Individual: also use phone numbers for display_name
Individual: also use phone numbers for display_name
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2018-01-04 11:13 UTC by Niels De Graef
Modified: 2018-01-04 12:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[Patch] Individual: Also use phone number for `display_name` (2.02 KB, patch)
2018-01-04 11:13 UTC, Niels De Graef 		committed Details | Review

Description Niels De Graef 2018-01-04 11:13:08 UTC 
Created attachment 366276 [details] [review]
[Patch] Individual: Also use phone number for  `display_name`

In GNOME Contacts, we recently got rid of the `display_name` in our wrapper class for Individual. However, we also would like to show the phone number if available before falling back to the postal address or "Unnamed person" (see also the original bug 727741). Bug 651672, which discussed adding the `display_name` property in folks, also contains a comment (the second one) about adding phone numbers as another fallback, but it somehow got ignored.

Attached is a patch to also use phone numbers as a fallback for the display_name property.
Comment 1 Philip Withnall 2018-01-04 11:47:21 UTC 
Review of attachment 366276 [details] [review]:

Looks reasonable to me, thanks.
Comment 2 Niels De Graef 2018-01-04 12:02:13 UTC 
Comment on attachment 366276 [details] [review]
[Patch] Individual: Also use phone number for  `display_name`

Landed on master as commit 4a634c7.
Comment 3 Philip Withnall 2018-01-04 12:07:18 UTC 
You can close bugs when pushing the last patch in them. :-)