After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792186 - dcaparse: don't mark buffer as discont if space before is just zero padding
dcaparse: don't mark buffer as discont if space before is just zero padding
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-04 01:10 UTC by Matej Knopp
Modified: 2018-11-03 15:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.28 KB, patch)
2018-01-04 01:11 UTC, Matej Knopp 		reviewed Details | Review

Description Matej Knopp 2018-01-04 01:10:45 UTC 
There seem to be files out there that have zero padded buffers, gstreamer
marks them as discont, which causes decoder flush and decoding artifacts

Sample file
https://s3.amazonaws.com/MatejK/Samples/dts_sfx_long_core_1080p-thedigitaltheater.mkv
Comment 1 Matej Knopp 2018-01-04 01:11:47 UTC 
Created attachment 366267 [details] [review]
Patch
Comment 2 Sebastian Dröge (slomo) 2018-01-04 10:40:01 UTC 
Comment on attachment 366267 [details] [review]
Patch

We have the same workarounds in so many places now. Maybe there should be a baseparse mode where it never inserts discount (unless flush) unless the subclass is explicitly setting it when data is skipped?
Comment 3 GStreamer system administrator 2018-11-03 15:25:09 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/430.