GNOME Bugzilla – Bug 792178
Use enumerated constants for EXIF flash values, metering modes and resolution units
Last modified: 2018-01-29 10:05:44 UTC
Currently src/libtracker-extract/tracker-exif.c has a list of integer literals to match the various EXIF flash values and metering modes. Without accompanying comments, particularly the flash values, it is hard to understand what these magic constants represent. It would be nicer to use enumerated constants instead. As far as I can see, there are no macros or constants defined by libexif or (g)exiv2. So we add our own private constants for them.
Created attachment 366255 [details] [review] libtracker-extract: Use enumerated constants for EXIF flash values
Created attachment 366256 [details] [review] libtracker-extract: Use enumerated constants for EXIF metering modes
Just to complete the paper trail, this came up in https://bugzilla.gnome.org/show_bug.cgi?id=787589#c11
Comment on attachment 366255 [details] [review] libtracker-extract: Use enumerated constants for EXIF flash values Looks good :)
Comment on attachment 366256 [details] [review] libtracker-extract: Use enumerated constants for EXIF metering modes nice!
Thanks for the reviews, Carlos!
Created attachment 367538 [details] [review] libtracker-extract, tracker-extract: Use enums for resolution units I had this another one in my tree which I had forgotten to attach before.
Comment on attachment 367538 [details] [review] libtracker-extract, tracker-extract: Use enums for resolution units Thanks :), that's quite more readable.