GNOME Bugzilla – Bug 792139
Toggle Enable shortcuts -> fading of shortcut keys delayed
Last modified: 2018-01-02 23:11:52 UTC
Preferences -> Shortcuts -> toggle Enable shortcuts Move the mouse slowly over the table underneath. Notice that the shortcut keys get (un)grayed out one by one, as you mouseover. Expected: All of them should toggle immediately. Happens both with Adwaita and Ambiance. --- terminal_accels_fill_treeview() sets up the column's renderer func to be accel_set_func, with userdata being disable_shortcuts_button (the widget). accel_set_func() sets the boolean writable based on this togglebutton's state, and sets sensitive/editable (the color is sure derived from the former) to this boolean. There should be some means to ask treeview(cell?renderer?whatever) to redraw if its desired rendering changed due to some external circumstance (somewhat analogously to gtk_list_box_invalidate_sort() for example). I just cannot find it. Maybe reinstall the same cell_data_func?
gtk_widget_queue_draw() ?
Yes, queuing a draw on the tree view when the pref changes should fix this.
Created attachment 366224 [details] [review] Yup Not sure whether I'd need to disconnect the signal, and lazy to study it. :) There are a lot of signal_connect's in the file, and only a few of them are disconnected.
Comment on attachment 366224 [details] [review] Yup That's fine, since the button's and the treeview's lifespan is the same.
Submitted.