After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792103 - Unify color pickers
Unify color pickers
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: Profiles
git master
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on: 774710
Blocks:
 
 
Reported: 2018-01-01 20:01 UTC by Egmont Koblinger
Modified: 2018-01-02 11:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Egmont Koblinger 2018-01-01 20:01:19 UTC 
Default/bold/cursor/highlight text/background color pickers use a different kind of color picker dialog than the 16 palette entries.
Comment 1 Christian Persch 2018-01-01 20:19:24 UTC 
I think they're just missing this bit:

#if GTK_CHECK_VERSION (3, 19, 8)
      g_object_set (w, "show-editor", TRUE, NULL);
#endif
Comment 2 Egmont Koblinger 2018-01-01 20:50:05 UTC 
Haha, there's a corresponding "ATTENTION: HACK HACK HACK!" in profile-editor.c.

Maybe the current behavior is intentional (or can be reasoned as if it was). For the 16 colors there's not much point in showing the "pick one from the palette" dialog since the chances of a user wanting to re-use something is minimal. For the bold/etc. colors there's a higher chance of them wanting to re-use a previously picked color.

Or maybe we should just ditch all these hacks and go with GTK+'s default, even if a tiny bit less usable for this particular scenario?
Comment 3 Christian Persch 2018-01-01 21:06:10 UTC 
It's only a hack on gtk < 3.20, so that's fine; I got it fixed there for 3.20. The current behaviour wasn't intentional; when I did this I simply forgot to do the non-palette colourpickers. And IMHO the 'pick from these few colours' mode of the colourpicker is *never* useful, so I think we should do the g_object_set() also for the other colourpickers.