After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792083 - GtkTable -> GtkGrid
GtkTable -> GtkGrid
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks: 774710 774712
 
 
Reported: 2017-12-31 17:27 UTC by Egmont Koblinger
Modified: 2018-01-01 19:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GtkGrid, v1 (58.46 KB, patch)
2017-12-31 17:27 UTC, Egmont Koblinger
committed Details | Review

Description Egmont Koblinger 2017-12-31 17:27:43 UTC
Created attachment 366126 [details] [review]
GtkGrid, v1

GtkTable is deprecated.

There are a couple of things that could be cleaned up in the glade files, let's begin with this.

On English UI I cannot see any difference with this patch. Chances are though that with some other locales there might be tiny differences (e.g. if the profile prefs' "General" tab isn't the widest tab, whether checkbox labels there expand fully to the right).

I couldn't find any automatic Table -> Grid converter, so it was manual work, especially with the fill/expand stuff that I just wiped out everywhere and re-added where seemed necessary.

I reordered the children to their natural order.

Dropped the "Terminal applications have these colors available to them" label, no clue where/when it's supposed to appear, I assume it's a leftover.
Comment 1 Christian Persch 2017-12-31 18:30:05 UTC
Comment on attachment 366126 [details] [review]
GtkGrid, v1

I havn't looked at the patched .ui file itself, only visually inspected the resulting UI which seems fine :-)
Comment 2 Egmont Koblinger 2018-01-01 14:13:35 UTC
(In reply to Egmont Koblinger from comment #0)

> I reordered the children to their natural order.

Forgot this at the "Theme variant" and "Open new terminals in" combo boxes. Will fix before submitting.

(In reply to Christian Persch from comment #1)

> I havn't looked at the patched .ui file itself, only visually inspected the
> resulting UI which seems fine :-)

I'm not planning any more UI changes for 3.28 (apart from bug 792095), but I might come up with a few more internal cleanups like this one. Worst case we'll just revert these.
Comment 3 Egmont Koblinger 2018-01-01 19:31:42 UTC
Submitted.