After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792048 - Show url for unnamed bookmarks
Show url for unnamed bookmarks
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Bookmarks
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-29 17:40 UTC by tichun
Modified: 2017-12-29 20:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
how it looks (14.82 KB, image/png)
2017-12-29 17:40 UTC, tichun 		  Details
bookmark-row: Display URL for bookmarks without title (2.30 KB, patch)
2017-12-29 20:33 UTC, Michael Catanzaro 		committed Details | Review

Description tichun 2017-12-29 17:40:30 UTC 
Created attachment 366084 [details]
how it looks

In firefox one can remove names from bookmarks and have lots of them on the bar and that is OK.
Syncing those to Epiphany makes the bookmark tab look empty.
The solution is to show the URL of a bookmark that has no name.
Comment 1 Michael Catanzaro 2017-12-29 20:16:50 UTC 
Oh wow! Yes indeed.
Comment 2 Michael Catanzaro 2017-12-29 20:17:55 UTC 
You don't even need Sync to do this. You can remove the titles in Epiphany as well.
Comment 3 Michael Catanzaro 2017-12-29 20:33:54 UTC 
The following fix has been pushed:
e505173 bookmark-row: Display URL for bookmarks without title
Comment 4 Michael Catanzaro 2017-12-29 20:33:57 UTC 
Created attachment 366090 [details] [review]
bookmark-row: Display URL for bookmarks without title

Bookmarks don't have to have a title. In that case, we should fall back
to displaying the URL.

Bookmarks don't have to have a URL either, but in that case, blank is
probably the best we can do.