GNOME Bugzilla – Bug 792047
glibmm and gtkmm-documentation: Modulesets need updates
Last modified: 2018-03-31 13:34:57 UTC
gnome-suites-core-deps-3.28.modules glibmm-2.4 shall check out the glibmm-2-54 branch (not glibmm-2-52). gnome-world.modules gtkmm-documentation shall depend on gtkmm (not gtkmm-3). A new gtkmm-3-documentation module shall depend of gtkmm-3. I'll attach two patches. Am I allowed to push such patches to the git repository without asking? I have a git account, and can push most types of patches to glibmm and gtkmm-documentation without asking in a bug report or otherwise. But I don't know the rules for pushing patches to jhbuild's modulesets.
Created attachment 366082 [details] [review] core-deps-3.28: glibmm-2.4 checks out the glibmm-2-54 branch
Created attachment 366083 [details] [review] world: Add gtkmm-3-documentation
(In reply to Kjell Ahlstedt from comment #0) > Am I allowed to push such patches to the git repository without asking? Yes! > I have a git account, and can push most types of patches to glibmm and > gtkmm-documentation without asking in a bug report or otherwise. > But I don't know the rules for pushing patches to jhbuild's modulesets. Feel free to push your changes.
Review of attachment 366083 [details] [review]: OK
Review of attachment 366082 [details] [review]: In this case, it's good that you posted these for review, because this is only half the needed change, and we would have missed it otherwise. I'll take care of the other half, which is to update the glibmm-2.4 version limit in the releng repo. But I'm a bit confused what the limit is supposed to be. Currently we have it set to 2.51, so glibmm-2.4 corresponds to the release with the highest version number lower than 2.51 (i.e. 2.50.1). But clearly that's not what you want. Should the limit be set to 2.55? Or might 2.56 become the next glibmm-2.4 branch?
Yes, 2.55 is a good limit, at least for the time being. No wonder that you're confused. Several recent unstable releases of glibmm (most of 2.51.x, all of 2.53.x and 2.55.x) belong to a coming ABI-breaking version that can be installed in parallel with glibmm-2.4. Unfortunately this ABI can't be called glibmm-3.0 because there will be no glib-3.0. Now we assume that this new ABI will be called glibmm-2.56, but it's not impossible that future glibmm 2.56.x releases will belong to the glibmm-2.4 ABI, and the new ABI will be called glibmm-2.58. If that happens, the limit in the releng repo should be changed again. I guess that you're still confused after having read this.
I didn't know about the releng repo before you mentioned it. Looking at the tarball-conversion[-stable].config files, I wonder if a second entry for cairomm should be added. Perhaps like so: <package name="cairomm-1.0" set="core" limit="1.15" module="cairomm"/>
OK, I'll change the glibmm-2.4 limit to 2.55. Just let me know if the stable limits need to be updated again. (In reply to Kjell Ahlstedt from comment #7) > I didn't know about the releng repo before you mentioned it. > Looking at the tarball-conversion[-stable].config files, I wonder if a second > entry for cairomm should be added. Perhaps like so: > > <package name="cairomm-1.0" set="core" limit="1.15" module="cairomm"/> I think we don't have that one because it's an old branch, not maintained on GNOME infrastructure, and nothing we release actually depends on it.
pangomm-1.4 and gtkmm-3 depend on cairomm-1.0.
OK, I'll add it. Thanks!
(In reply to Michael Catanzaro from comment #8) > OK, I'll change the glibmm-2.4 limit to 2.55. Just let me know if the stable > limits need to be updated again. Now the glibmm-2.4 limit in releng should be changed to 2.57. glibmm 2.56.0 has been released, belonging to the glibmm-2.4 ABI. The new and parallel-installable ABI is called glibmm-2.58. But I would not be surprised if it will be changed once again. It depends on when the new ABI will become stable. Now I'm confused. Shall I change the checkout branch of glibmm-2.4 to glibmm-2-56 in gnome-suites-core-deps-latest.modules or in gnome-suites-core-deps-3.28.modules or in both?
(In reply to Kjell Ahlstedt from comment #11) > (In reply to Michael Catanzaro from comment #8) > > OK, I'll change the glibmm-2.4 limit to 2.55. Just let me know if the stable > > limits need to be updated again. > > Now the glibmm-2.4 limit in releng should be changed to 2.57. > glibmm 2.56.0 has been released, belonging to the glibmm-2.4 ABI. > > The new and parallel-installable ABI is called glibmm-2.58. But I would not > be > surprised if it will be changed once again. It depends on when the new ABI > will > become stable. > > > Now I'm confused. Shall I change the checkout branch of glibmm-2.4 to > glibmm-2-56 in gnome-suites-core-deps-latest.modules or in > gnome-suites-core-deps-3.28.modules or in both? We don't maintain the JHBuild modulesets anymore: the action is in https://gitlab.gnome.org/GNOME/gnome-build-meta now. But I guess you would want to change it in both, because glibmm-2-56 is the last release of the glibmm-2.4 API, right?
(In reply to Kjell Ahlstedt from comment #11) > Now the glibmm-2.4 limit in releng should be changed to 2.57. > glibmm 2.56.0 has been released, belonging to the glibmm-2.4 ABI. Done!