After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792038 - gnumeric-1.12.38/src/ssdiff.c:1227: suspicious code
gnumeric-1.12.38/src/ssdiff.c:1227: suspicious code
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
1.12.x
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2017-12-29 08:42 UTC by dcb
Modified: 2017-12-29 13:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description dcb 2017-12-29 08:42:16 UTC 
gnumeric-1.12.38/src/ssdiff.c:1227]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.

      if (!nn || (on && cb_expr_name_by_name (on, nn)) < 0) {

Maybe better code

      if (!nn || (on && (cb_expr_name_by_name (on, nn) < 0))) {
Comment 1 Morten Welinder 2017-12-29 13:19:07 UTC 
Thanks -- two occurrences of that.

This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.