After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791989 - FreeBSD's sed doesn't allow putting '}' on the same line as 'd' command
FreeBSD's sed doesn't allow putting '}' on the same line as 'd' command
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other FreeBSD
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2017-12-27 17:45 UTC by Ting-Wei Lan
Modified: 2017-12-28 14:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
configure: Fix the usage of sed on FreeBSD (1020 bytes, patch)
2017-12-27 17:50 UTC, Ting-Wei Lan
none Details | Review

Description Ting-Wei Lan 2017-12-27 17:45:11 UTC
This problem happens after the recent commit 7d3adc8. It is easy to fix. We just need to replace '-e "d }"' with '-e "d" -e "}"'.

config.status: executing po-libgimp/stamp-it commands
sed: 1: "d }
": extra characters at the end of d command
config.status: executing po-python/stamp-it commands
sed: 1: "d }
": extra characters at the end of d command
config.status: executing po-plug-ins/stamp-it commands
sed: 1: "d }
": extra characters at the end of d command
config.status: executing po-script-fu/stamp-it commands
sed: 1: "d }
": extra characters at the end of d command
config.status: executing po-tips/stamp-it commands
sed: 1: "d }
": extra characters at the end of d command
config.status: executing po-windows-installer/stamp-it commands
sed: 1: "d }
": extra characters at the end of d command
config.status: executing po/stamp-it commands

Making all in po-libgimp
gmake[2]: Entering directory '/home/lantw44/gnome/build/gimp/po-libgimp'
gmake[2]: *** No rule to make target 'all'.  Stop.
Comment 1 Ting-Wei Lan 2017-12-27 17:50:06 UTC
Created attachment 366022 [details] [review]
configure: Fix the usage of sed on FreeBSD

FreeBSD requires the right brace to be preceded by a newline. Putting it
on the same line as other commands is not allowed.
Comment 2 Jehan 2017-12-28 14:20:49 UTC
Thanks!
Making portable scripts with these commands is always hard. ;-)

Pushed.

commit bccaf39dc9a61d9592b7650bcf1b243e7f6ae314 (HEAD -> master, origin/master, origin/HEAD)
Author: Ting-Wei Lan <lantw@src.gnome.org>
Date:   Thu Dec 28 01:45:02 2017 +0800

    configure: Fix the usage of sed on FreeBSD
    
    FreeBSD requires the right brace to be preceded by a newline. Putting it
    on the same line as other commands is not allowed.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=791989

 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)