GNOME Bugzilla – Bug 791939
Add xdg-shell (stable) support
Last modified: 2018-05-02 19:38:09 UTC
Add support for the stable xdg-shell protocol. It adds support alongside xdg-shell unstable v6, but will only fall back to the unstable version if the stable version is not advertised by the display server.
Created attachment 365963 [details] [review] wayland: Add support for xdg-shell stable This commit adds support the stable version of the xdg-shell protocol. Support for the last version of the unstable series is left intact, but will not receive new features. The stable version is prioritized above the older version.
Created attachment 365964 [details] [review] wayland: Minor whitespace cleanups Broke up a long line, added an empty one, and indented another one.
I have trouble getting this to generate the protocol sources. Maybe I'm missing something. If it works for you, can also do a similar patch for master ?
What's the error when generating protocol sources? Regarding master, I was thinking of just replacing xdg_shell unstable v6 with xdg_shell stable, dropping the support for the old. Or is there any point in supporting legacy protocol in gtk4?
(In reply to Jonas Ådahl from comment #4) > What's the error when generating protocol sources? They just don't seem to get generated... I've re-autogen'ed, and still, no sign of these files after a build.
(In reply to Matthias Clasen from comment #5) > (In reply to Jonas Ådahl from comment #4) > > What's the error when generating protocol sources? > > They just don't seem to get generated... I've re-autogen'ed, and still, no > sign of these files after a build. Strange. I just tried git clean -fdx ./autogen make -C gdk -j8 It built fine and I can see gdk/wayland/xdg-shell-client-protocol.h in there. Can you double check that wayland-protocols 1.12 is the version installed? It seems autotools will automagically disable the wayland backend if the version is not new enough when you run autogen.sh.
(In reply to Jonas Ådahl from comment #4) > Regarding master, I was thinking of just replacing xdg_shell unstable v6 > with xdg_shell stable, dropping the support for the old. Or is there any > point in supporting legacy protocol in gtk4? Weston doesn't have a stable xdg_shell implementation yet, right?
(In reply to Daniel Stone from comment #7) > (In reply to Jonas Ådahl from comment #4) > > Regarding master, I was thinking of just replacing xdg_shell unstable v6 > > with xdg_shell stable, dropping the support for the old. Or is there any > > point in supporting legacy protocol in gtk4? > > Weston doesn't have a stable xdg_shell implementation yet, right? Not that I know of. I guess an alternative is to wait with replacing it until it has one. My point is mostly that it'd be nice to start with a "clean slate" with gtk4 with less legacy cruft.
Ah, I have an older version of wayland-protocols in my jhbuild tree. Building against the one in /usr worked. So, looks good to go then, as far as I'm concerned. Can you look bringing this to master, too ?
Added https://gitlab.gnome.org/GNOME/gtk/merge_requests/35 and https://gitlab.gnome.org/GNOME/gtk/merge_requests/36
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/999.