After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791903 - Remove unused icon loading code in utils module
Remove unused icon loading code in utils module
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2017-12-23 20:50 UTC by Marcus Lundblad
Modified: 2017-12-23 20:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
utils: Remove unused code (2.43 KB, patch)
2017-12-23 20:51 UTC, Marcus Lundblad 		committed Details | Review

Description Marcus Lundblad 2017-12-23 20:50:57 UTC 
When developing the Wikipedia thumbnail functionallity I discovered some old code in utils.js to read icons from HTTP(S) streams. I found this has never been used (and probably doesn't work as it was). Re-implemented a version of this generating a bare GdkPixbuf in the new wikipedia.js module. So remove this old code.
Comment 1 Marcus Lundblad 2017-12-23 20:51:43 UTC 
Created attachment 365910 [details] [review]
utils: Remove unused code

Remove unused (and I think not-quite working anyway)
functionalliy to load icons from HTTP streams.
Comment 2 Marcus Lundblad 2017-12-23 20:52:34 UTC 
Attachment 365910 [details] pushed as 39a6a49 - utils: Remove unused code