After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791893 - Camera-developed JPG ignored when importing DNG
Camera-developed JPG ignored when importing DNG
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: raw
0.26.x
Other Linux
: Normal major
: ---
Assigned To: Shotwell Maintainers
Shotwell Maintainers
: 742809 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-12-23 14:09 UTC by Michael
Modified: 2018-03-07 15:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't wrongly fall back to shotwell developer (1.16 KB, patch)
2017-12-24 13:15 UTC, Jens Georg
committed Details | Review

Description Michael 2017-12-23 14:09:57 UTC
Importing photos from my OnePlus Two (shot with HDR) results imported RAW+JPEG being developed by Shotwell, even though the settings are different. As a consequence, the resulting JPG is way too dark and grey-ish.

See https://share.mhoff.net/171223_shotwell_bug.zip (file size exceeds attachment restrictions) for a test case.

The files
- IMG_20160903_172239_1.jpg
- IMG_20160903_172239_1.dng
physically reside on my mobile phone SD card.

When importing those, the files
- IMG_20160903_172239_1.jpg
- IMG_20160903_172239_1.dng
- IMG_20160903_172239_dng_shotwell.jpg
are placed in my $HOME/Pictures folder.
As you can see, the file generated by shotwell (suffix "_dng_shotwell.jpg") is way too dark and does not even remotely match the quality of the jpg-file generated by the phone.

Still, shotwell chooses to render the dng-file itself, completely ignores the phone-generated jpg-file and, even though the default developer is "Camera" *and* I manually set the developer to "Camera", shotwell sticks with its jpg-version of the file.

I figure this bug might be related to RAW+JPEG pair discovery. However, I also tried to first copy the files to my local filesystem and import them from there, but still, shotwell chooses to develop the image itself.
Comment 1 Michael 2017-12-23 14:11:41 UTC
Please ignore the "_1" part of the file-names. These are results from multiple attempts to fix the problem.
Comment 2 Jens Georg 2017-12-24 12:41:08 UTC
Can you check what your default RAW developer is set to? The image quality and naming suggests that it is set to Shotwell, not Camera. You can check this in Edit -> Preferences, right at the bottom.
Comment 3 Jens Georg 2017-12-24 12:43:56 UTC
Meh, sorry. Didn't read properly.
Comment 4 Jens Georg 2017-12-24 13:15:32 UTC
Created attachment 365931 [details] [review]
Don't wrongly fall back to shotwell developer

If we requested CAMERA development, but the RAW file did not have any
preview embedded, Shotwell falls back to the SHOTWELL developer, even
though we have the camera-developed fle available

Only fall back to SHOTWELL if embedded was chosen and embedded is not
available.
Comment 5 Jens Georg 2017-12-24 13:45:07 UTC
Attachment 365931 [details] pushed as b80a42d - Don't wrongly fall back to shotwell developer
Comment 6 Jens Georg 2018-03-07 15:52:22 UTC
*** Bug 742809 has been marked as a duplicate of this bug. ***