After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791889 - _gda_postgres_compute_version doesn't consider database version with more than one digit
_gda_postgres_compute_version doesn't consider database version with more tha...
Status: RESOLVED OBSOLETE
Product: libgda
Classification: Other
Component: PostgreSQL provider
5.2.x
Other Linux
: Normal normal
: ---
Assigned To: malerba
gnome-db Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-23 11:14 UTC by Andrea Zagli
Modified: 2018-09-21 13:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the patch to fix the problem (62.76 KB, patch)
2017-12-23 11:14 UTC, Andrea Zagli 		none Details | Review

Description Andrea Zagli 2017-12-23 11:14:37 UTC 
Created attachment 365898 [details] [review]
the patch to fix the problem

Meta store is empty because there's a bug in _gda_postgres_compute_version, that doesn't consider database version with more than one digit
Comment 1 Pavlo Solntsev 2018-03-09 19:57:19 UTC 
Could you please clean your patch? It contains trilling lines and unnecessary inserted spaces. git apply --check <patch> may help.
Comment 2 Andrea Zagli 2018-03-17 08:33:43 UTC 
The patch applies without prolems to HEAD on branch 5.2.

There're only EOL changes, no trilling lines and unnecessary spaces.

I think it's useful to have uniform encoding and EOL in source files.

But if you want i can clean the patch.
Comment 3 Pavlo Solntsev 2018-03-17 20:16:32 UTC 
Yes, please. Don't edit lines that are not involved into the modification.
Comment 4 Andrea Zagli 2018-03-17 21:43:09 UTC 
useless waste of time, i'll do asap
Comment 5 GNOME Infrastructure Team 2018-09-21 13:59:30 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libgda/issues/134.