After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791666 - Cerbero: taglib fails to build on macos
Cerbero: taglib fails to build on macos
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
unspecified
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-16 00:18 UTC by Xavier Claessens
Modified: 2017-12-21 10:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
OSX: Build cmake in bootstrap (1.29 KB, patch)
2017-12-17 03:59 UTC, Xavier Claessens
none Details | Review
OSX: Build cmake in bootstrap (1.25 KB, patch)
2017-12-20 19:22 UTC, Xavier Claessens
committed Details | Review

Description Xavier Claessens 2017-12-16 00:18:23 UTC
taglib needs cmake and it is not built as part of the bootstrap.
Comment 1 Xavier Claessens 2017-12-16 00:19:39 UTC
Probably needed for windows bootstrap as well. On linux distro packages are installed.
Comment 2 Xavier Claessens 2017-12-16 02:18:44 UTC
Actually README says to install it on the system, but it works fine to build it in cerbero, maybe that can be simplified.
Comment 3 Nicolas Dufresne (ndufresne) 2017-12-16 14:40:35 UTC
++ it's likely the build-tool recipe was added later without any further consideration for OSX, iOS (and Windows ?)
Comment 4 Xavier Claessens 2017-12-17 03:59:40 UTC
Created attachment 365633 [details] [review]
OSX: Build cmake in bootstrap
Comment 5 Nicolas Dufresne (ndufresne) 2017-12-20 19:18:43 UTC
Review of attachment 365633 [details] [review]:

Can you rebase.
Comment 6 Xavier Claessens 2017-12-20 19:22:07 UTC
Created attachment 365800 [details] [review]
OSX: Build cmake in bootstrap
Comment 7 Nicolas Dufresne (ndufresne) 2017-12-20 19:38:23 UTC
Attachment 365800 [details] pushed as a215cf0 - OSX: Build cmake in bootstrap
Comment 8 Nicolas Dufresne (ndufresne) 2017-12-20 19:39:23 UTC
Thanks. I wonder if that would work on Windows too, I just like the idea of reducing the steps when running cerbero (even though on this side, it's already quite good)
Comment 9 Sebastian Dröge (slomo) 2017-12-20 19:53:23 UTC
The reason why cmake was not built by cerbero is that it often failed in interesting ways. During its own build or when building other software.
Comment 10 Nicolas Dufresne (ndufresne) 2017-12-20 19:59:02 UTC
It does not seem to be an issue today. We have run this on old RHEL and now OSX without hitting what you describe as the historical reason. If you are referring to Windows, well, let's mention it in the future bug, if we decide to go ahead. Currently building GStreamer on Windows is pretty much in the state you just described cmake here.
Comment 11 Xavier Claessens 2017-12-20 20:21:27 UTC
(In reply to Sebastian Dröge (slomo) from comment #9)
> The reason why cmake was not built by cerbero is that it often failed in
> interesting ways. During its own build or when building other software.

Hm, let's see what CI thinks about it now. Worst case it's trivial to revert :-)
Comment 12 Sebastian Dröge (slomo) 2017-12-20 20:34:22 UTC
(In reply to Nicolas Dufresne (stormer) from comment #10)
> Currently building GStreamer on Windows is pretty much in the
> state you just described cmake here.

Not really, it works fine at least for Jan, Nirbheek and myself. Unless someone breaks something again and it does not show up on Jenkins.

Other people seem to have problems building though, there seem to be various parts of the environment that are important to set up correctly but unclear what those all are. If I take a clean Windows install and follow the docs, it is working (or was at least last time I was trying that about a year ago).
Comment 13 Nicolas Dufresne (ndufresne) 2017-12-20 21:31:52 UTC
(In reply to Sebastian Dröge (slomo) from comment #12)
> (In reply to Nicolas Dufresne (stormer) from comment #10)
> > Currently building GStreamer on Windows is pretty much in the
> > state you just described cmake here.
> 
> Not really, it works fine at least for Jan, Nirbheek and myself. Unless
> someone breaks something again and it does not show up on Jenkins.

Clarification, Jenkins does not run anything natively on Windows.

> 
> Other people seem to have problems building though, there seem to be various
> parts of the environment that are important to set up correctly but unclear
> what those all are. If I take a clean Windows install and follow the docs,
> it is working (or was at least last time I was trying that about a year ago).

Like parallel builds being enabled but racy ?
Comment 14 Sebastian Dröge (slomo) 2017-12-20 22:10:58 UTC
Parallel builds are disabled by default on Windows for that very reason
Comment 15 Tim-Philipp Müller 2017-12-20 22:31:37 UTC
IIRC there are still problems with msgmerge/msgfmt on windows (they sometimes crash), and I also seem to remember seeing configure sometimes just spinning/being stuck forever, but not sure if anyone else has reported that as wel.
Comment 16 Sebastian Dröge (slomo) 2017-12-21 10:24:27 UTC
Those never happened to me since years, but I think they are a result of weird compilation problems of gettext.

What I sometimes have is that the msys shell itself can't start, or the perl from msys. Complaining about weird Windows issues, and then usually work after a reboot. Which also might be the cause of the gettext issues.