After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791579 - Place bubble moves with screen when moving map with arrow keys
Place bubble moves with screen when moving map with arrow keys
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: map view
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2017-12-13 14:05 UTC by David Jones
Modified: 2017-12-20 21:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Place bubble position after moving maps with arrow keys (278.83 KB, image/png)
2017-12-13 14:05 UTC, David Jones
  Details
mapMarker: Move map bubble when map view moves (1.60 KB, patch)
2017-12-14 21:59 UTC, Marcus Lundblad
committed Details | Review

Description David Jones 2017-12-13 14:05:18 UTC
Created attachment 365491 [details]
Place bubble position after moving maps with arrow keys

Hi, 

When a place bubble is displayed, if you move the map with the arrow keys the place bubble remains visible and moves with the screen rather than staying fixed to the pin location. See the attached screen shot. 

If you move the map with the mouse the place bubble disappears. I'm assuming the arrow keys behaviour needs to be updated to match that of the mouse click?

Cheers,

David
Comment 1 Marcus Lundblad 2017-12-14 21:59:02 UTC
Created attachment 365562 [details] [review]
mapMarker: Move map bubble when map view moves

When a map marker is visible and the view moves
(i.e. when using arrow keys) move the bubble as
well. Hide it when when marker goes out of view.
Comment 2 Marcus Lundblad 2017-12-15 07:12:05 UTC
(In reply to David Jones from comment #0)
> Created attachment 365491 [details]
> Place bubble position after moving maps with arrow keys
> 
> Hi, 
> 
> When a place bubble is displayed, if you move the map with the arrow keys
> the place bubble remains visible and moves with the screen rather than
> staying fixed to the pin location. See the attached screen shot. 
> 
> If you move the map with the mouse the place bubble disappears. I'm assuming
> the arrow keys behaviour needs to be updated to match that of the mouse
> click?
> 
> Cheers,
> 
> David

Hi!

Thanks for reporting this bug!
I cooked up a small patch that makes the bubbles follow the marker, and it is dismissed when the marker goes out-of-view.
Comment 3 David Jones 2017-12-15 11:43:36 UTC
Thanks and happy to get involved!
Comment 4 Marcus Lundblad 2017-12-20 21:22:04 UTC
Attachment 365562 [details] pushed as 17c0d79 - mapMarker: Move map bubble when map view moves