After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791505 - critical when parsing a directory read from a rar archive through lsar
critical when parsing a directory read from a rar archive through lsar
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
3.26.x
Other Linux
: Normal minor
: ---
Assigned To: file-roller-maint
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2017-12-12 03:33 UTC by Mike Gorse
Modified: 2017-12-12 12:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.21 KB, patch)
2017-12-12 03:39 UTC, Mike Gorse 		none Details | Review

Description Mike Gorse 2017-12-12 03:33:59 UTC 
When scanning an archive via lsar and encountering a directory, file-roller outputs a json-related critical. It is trying to read a size from all entries returned by lsar, including directories which do not have a XADFileSize member.
Comment 1 Mike Gorse 2017-12-12 03:39:42 UTC 
Created attachment 365405 [details] [review]
Proposed patch

An alternative to this patch would be to read the size only for entries that are not directories.
Comment 2 Paolo Bacchilega 2017-12-12 12:01:50 UTC 
Patch applied to both master and gnome-3-26, thank you.