After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791480 - Fix documentation generation
Fix documentation generation
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gitg
git master
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2017-12-11 14:19 UTC by Iñigo Martínez
Modified: 2017-12-11 15:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix documentation generation (1.01 KB, patch)
2017-12-11 14:21 UTC, Iñigo Martínez
none Details | Review
Fix documentation generation (1.10 KB, patch)
2017-12-11 14:37 UTC, Iñigo Martínez
committed Details | Review

Description Iñigo Martínez 2017-12-11 14:19:48 UTC
The documentation can't be generated due to the following error:

  gitg-ext-activity.vala:36.5-36.12: error: expected <end-of-line>
    * Returns %TRUE if the activity is the default activity for @action,
    ^^^^^^^
Comment 1 Iñigo Martínez 2017-12-11 14:21:38 UTC
Created attachment 365368 [details] [review]
Fix documentation generation

The GitgExt.Activity class is not properly documented due to missing @return taglet.

This patchs adds the missing taglet allowing documentation to be generated properly.
Comment 2 Iñigo Martínez 2017-12-11 14:37:15 UTC
Created attachment 365369 [details] [review]
Fix documentation generation

This patch update should use the proper words and indentation.
Comment 3 Ignacio Casal Quinteiro (nacho) 2017-12-11 15:09:17 UTC
Review of attachment 365369 [details] [review]:

Fine for me
Comment 4 Iñigo Martínez 2017-12-11 15:13:15 UTC
Comment on attachment 365369 [details] [review]
Fix documentation generation

Pushed as 5b6d2cd5 - Fix documentation generation