After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791452 - ambigous width of some line drawing characters
ambigous width of some line drawing characters
Status: RESOLVED OBSOLETE
Product: vte
Classification: Core
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-10 21:00 UTC by Christian Persch
Modified: 2021-06-10 15:27 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Persch 2017-12-10 21:00:43 UTC
In commit 02da6534a721f09619962ca24aa287b2a36bd630 (bug 732586), there seems to have been a inadvertent change to the width of some ambiguous-width characters.

iso2022.c contained this:

-static gboolean
-_vte_unichar_iswide_cjk(gunichar c)
-{
-        /* U+254C..U+254F and U+2574..U+257F have East Asian Width property
-         * N (neutral) while all the other line drawing characters are
-         * A (ambigous). This makes those characters not match up with those
-         * other line drawing characters from the Box Drawing (U+2500..U+257F)
-         * block; so we treat them as ambigous too.
-         *
-         * And we also do the same for the Terminal Graphic Characters
-         * (U+2596..U+259F) as well as U+2590 and U+2591 from the Block Elements 
-         * (U+2580..U+259F) block.
-         */
-        return G_UNLIKELY(c >= 0x2500 && c <= 0x259f);
-}
-
-static inline gboolean
-_vte_iso2022_is_ambiguous(gunichar c)
-{
-       if (G_LIKELY (c < 0x80))
-               return FALSE;
-       if (G_UNLIKELY (g_unichar_iszerowidth (c)))
-               return FALSE;
-       return G_UNLIKELY (!g_unichar_iswide (c) && (g_unichar_iswide_cjk (c) || _vte_unichar_iswide_cjk (
c)));
-}

which was lost in the move.

That is, when the setting to make ambiguous characters wide is used, U+254C..U+254F and U+2574..U+257F will now be narrow, while previously they were considered wide.
Comment 1 GNOME Infrastructure Team 2021-06-10 15:27:55 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/vte/-/issues/2458.