After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791449 - x/xvimagesink: Crop Meta support only works if the proposed pool has been used
x/xvimagesink: Crop Meta support only works if the proposed pool has been used
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 746087
 
 
Reported: 2017-12-10 20:12 UTC by Nicolas Dufresne (ndufresne)
Modified: 2018-11-03 12:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Nicolas Dufresne (ndufresne) 2017-12-10 20:12:00 UTC 
Whenever the proposed pool is not used upstream, the element fails. The reason is that buffer containing crop meta are larger then caps width/height used to create the internal pool.

We need to delay the creation of the pool, and then alter the caps width/height with the width/height found in the incoming buffer video meta. As a side effect, we also need to validate this width/height every-time.

I'll post the videocrop patches needed to test this easily soon, meanwhile the test pipeline will be:

  videotestsrc ! videocrop top=100 ! tee ! xvimagesink

Tee does not drop the allocation query, but will not use downstream pools.
Comment 1 Nicolas Dufresne (ndufresne) 2017-12-10 20:14:38 UTC 
The result is a black or green image (depends on the color format) and:

  CRITICAL **: gst_video_frame_copy: assertion 'dinfo->width == sinfo->width && dinfo->height == sinfo->height' failed
Comment 2 Nicolas Dufresne (ndufresne) 2017-12-10 21:07:09 UTC 
To test this, use this patch: https://bugzilla.gnome.org/show_bug.cgi?id=791453
Comment 3 GStreamer system administrator 2018-11-03 12:02:07 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/406.