After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791445 - glwindow/cocoa: Implement set_render_rectangle
glwindow/cocoa: Implement set_render_rectangle
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Mac OS
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-10 18:16 UTC by Philippe Normand
Modified: 2017-12-30 12:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (4.82 KB, patch)
2017-12-26 13:26 UTC, Philippe Normand 		none Details | Review
proposed patch (4.77 KB, patch)
2017-12-26 13:31 UTC, Philippe Normand 		committed Details | Review

Description Philippe Normand 2017-12-10 18:16:05 UTC 
This is needed when glimagesink is combined with GstVideoOverlay.
Comment 1 Philippe Normand 2017-12-26 13:26:17 UTC 
Created attachment 365982 [details] [review]
proposed patch
Comment 2 Philippe Normand 2017-12-26 13:31:35 UTC 
Created attachment 365983 [details] [review]
proposed patch
Comment 3 Matthew Waters (ystreet00) 2017-12-30 11:07:57 UTC 
Review of attachment 365983 [details] [review]:

Only a nit. Otherwise looks fine.

::: gst-libs/gst/gl/cocoa/gstglwindow_cocoa.m
@@ +88,3 @@
     GstGLWindowCB callback, gpointer data, GDestroyNotify destroy);
+static gboolean gst_gl_window_cocoa_set_render_rectangle (GstGLWindow *
+                                                          window, gint x, gint y, gint width, gint height);

That is some weird formatting :D
Comment 4 Philippe Normand 2017-12-30 12:20:30 UTC 
Huh. Yeah, I should teach my emacs how to format Obj-C at some point :) Thanks for the review!
Comment 5 Philippe Normand 2017-12-30 12:26:41 UTC 
commit 5d35e1fa15744b48c406fffa98695478fc8c9969 (HEAD -> master, origin/master, origin/HEAD)
Author: Philippe Normand <philn@igalia.com>
Date:   Tue Dec 26 13:23:11 2017 +0000

    gl: cocoa: Implement set_render_rectangle
    
    Resize the internal NSView according to the provided render rectangle.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=791445
Comment 6 Philippe Normand 2017-12-30 12:31:16 UTC 
I forgot to fix the definition of the function so I pushed a follow-up. Sorry about this :)