GNOME Bugzilla – Bug 791403
Buggy entry completion
Last modified: 2017-12-15 23:14:11 UTC
Looking for "San Cristóbal de las Casas" or "San Cristobal de las Casas" doesn't return anything, but geocode-glib can return data: $ ./geocode-glib "San Cristóbal de las Casas" Got geocode search answer: San Cristóbal de las Casas, Chiapas @ 16.683547, -92.615518 Got geocode search answer: San Cristóbal de Las Casas, Chiapas @ 16.735377, -92.638730 Got geocode search answer: San Cristóbal de las Casas, Querétaro @ 20.649517, -100.409989 Got geocode search answer: San Cristóbal de Las Casas, Chihuahua @ 28.576041, -106.114599 Got geocode search answer: San Cristobal de las Casas, Quintana Roo @ 21.148832, -86.846299 Looking for just "San Cristobal" has a fair number of entries, but it looks like there's duplicates and none have sufficient information to know whether it's the right place.
Created attachment 365365 [details] [review] location-entry: Fix completion entries that can't be differentiated In commit 6787563, we started stripping the country from geocode-glib results. But the last element was not always the country, but other differentiating information (such as the state, or province) if all the results were in the same country. And the statement: "remove the country part, which will be readded by libgweather anyway." doesn't seem to be correct anymore. This fixes the unusable completion popup when there's no differentiating information between the results.
Attachment 365365 [details] pushed as d64b60a - location-entry: Fix completion entries that can't be differentiated
*** Bug 791665 has been marked as a duplicate of this bug. ***