After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791391 - gl: error message when wayland display is not found
gl: error message when wayland display is not found
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-08 13:43 UTC by Víctor Manuel Jáquez Leal
Modified: 2017-12-11 21:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gl: display: demote error level at display creation error (2.15 KB, patch)
2017-12-08 13:47 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description Víctor Manuel Jáquez Leal 2017-12-08 13:43:29 UTC 
gstreamer-vaapi uses gst_gl_ensure_element_data() to get o create a GL display if it is available.

The creation of a gl display in gst_gl_display_new() is a try-and-error mechanism.

Since commit 472b8a37 not Wayland display is tried first in gst_gl_display_new(). The problem is, if the windowing system is XOrg, an error log message is printed in console:

0:00:00.263750821 22854 0x7fffec17aa80 ERROR              gldisplay gstgldisplay_wayland.c:131:gst_gl_display_wayland_new: Failed to open Wayland display connection.

The same happened, before commit 472b8a37, when running Wayland without XWayland support.

My proposal is to demote the error level for the functions gst_gl_*_new() to INFO or WARNING
Comment 1 Víctor Manuel Jáquez Leal 2017-12-08 13:47:40 UTC 
Created attachment 365247 [details] [review]
gl: display: demote error level at display creation error
Comment 2 Tim-Philipp Müller 2017-12-08 18:09:09 UTC 
Comment on attachment 365247 [details] [review]
gl: display: demote error level at display creation error

Seems fine to me. I have no opinion on WARNING vs. INFO, but leaning towards INFO as these are often normal and expected failure cases.
Comment 3 Víctor Manuel Jáquez Leal 2017-12-11 21:49:16 UTC 
Attachment 365247 [details] pushed as c0d87b5 - gl: display: demote error level at display creation error