After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791343 - build: Icons are not installed with Meson
build: Icons are not installed with Meson
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-12-07 14:37 UTC by Debarshi Ray
Modified: 2017-12-19 10:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Fix icons installation (6.85 KB, patch)
2017-12-08 20:17 UTC, Iñigo Martínez 		committed Details | Review

Description Debarshi Ray 2017-12-07 14:37:21 UTC 
Iñigo pointed this out for gnome-documents [1], and I see that gnome-boxes suffers from the same problem. The icons are currently not installed (to $datadir/icons/hicolor) with Meson.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=787013#c21
Comment 1 Iñigo Martínez 2017-12-08 20:17:21 UTC 
Created attachment 365273 [details] [review]
build: Fix icons installation

Looking at meson's build files, it expects a directory tree which is not present. However, the icons' files that are present work properly with autotools.

This patch creates the proper directory tree, renames all files' names to their final names, and also modifies both autotools' and meson's build files to install these files properly.
Comment 2 Felipe Borges 2017-12-19 10:31:42 UTC 
Review of attachment 365273 [details] [review]:

Thank you!
Comment 3 Felipe Borges 2017-12-19 10:34:46 UTC 
Attachment 365273 [details] pushed as a8081e3 - build: Fix icons installation