After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791331 - x264enc: add 'insert-vui' property
x264enc: add 'insert-vui' property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-07 07:00 UTC by Justin Kim
Modified: 2017-12-08 20:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
x264enc: add 'use-vui' property for users to choose (3.77 KB, patch)
2017-12-07 07:00 UTC, Justin Kim 		none Details | Review
x264enc: add 'insert-vui' property (3.80 KB, patch)
2017-12-08 02:36 UTC, Justin Kim 		committed Details | Review

Description Justin Kim 2017-12-07 07:00:33 UTC 
Created attachment 365179 [details] [review]
x264enc: add 'use-vui' property for users to choose

VUI(Video Usability Information) parameters should be set
according to the specification. However, some of the existing
hardware decoders refuse to decode in certain combinations of
the resolution and VUI parameters. To support the legacy
decoders, this patch provides 'use-vui' to skip the settings.
Comment 1 Olivier Crête 2017-12-07 19:11:49 UTC 
Review of attachment 365179 [details] [review]:

Patch is good, I just don't like the use-vui name as we're not using a VUI, we're creating and inserting it (hence the propose rename to "insert-vui")

::: ext/x264/gstx264enc.c
@@ +943,3 @@
+  g_object_class_install_property (gobject_class, ARG_SLICED_THREADS,
+      g_param_spec_boolean ("use-vui", "Use VUI",
+          "Use VUI when encoder is initialized",

Description should be somethign like "Insert VUI NAL in stream", and maybe the name of the param should be something like "insert-vui"
Comment 2 Justin Kim 2017-12-08 02:36:33 UTC 
Created attachment 365222 [details] [review]
x264enc: add 'insert-vui' property

Rename to 'insert-vui'
Comment 3 Olivier Crête 2017-12-08 20:41:28 UTC 
Patch merged, looks good