After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791319 - Actually validate the Locations.xml file
Actually validate the Locations.xml file
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: future
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks:
 
 
Reported: 2017-12-06 19:56 UTC by Bastien Nocera
Modified: 2017-12-07 00:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
locations: Actually validate the Locations.xml (798 bytes, patch)
2017-12-06 19:56 UTC, Bastien Nocera 		committed Details | Review
locations: Fix innocuous ordering error in Locations.xml (1.26 KB, patch)
2017-12-06 19:57 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2017-12-06 19:56:50 UTC 
.
Comment 1 Bastien Nocera 2017-12-06 19:56:56 UTC 
Created attachment 365149 [details] [review]
locations: Actually validate the Locations.xml

xmllint was run without the "--valid" option, so would just check the
XML for syntax errors, and wouldn't validate it against the DTD.
Comment 2 Bastien Nocera 2017-12-06 19:57:09 UTC 
Created attachment 365150 [details] [review]
locations: Fix innocuous ordering error in Locations.xml

Locations.xml:7883: element city: validity error : Element city content does not follow the DTD, expecting ((_name | name+) , coordinates? , tz-hint? , location+), got (_name coordinates location tz-hint )

It didn't impact on our parsing though.
Comment 3 Bastien Nocera 2017-12-07 00:30:38 UTC 
Attachment 365149 [details] pushed as 8e68a7b - locations: Actually validate the Locations.xml
Attachment 365150 [details] pushed as 81dbf77 - locations: Fix innocuous ordering error in Locations.xml