After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791313 - Deprecated code removal
Deprecated code removal
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: future
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks: 791327
 
 
Reported: 2017-12-06 17:21 UTC by Bastien Nocera
Modified: 2017-12-07 00:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
data: Update README.timezones for current UI (1.16 KB, patch)
2017-12-06 17:21 UTC, Bastien Nocera
committed Details | Review
data: Remove check-timezones.sh (2.03 KB, patch)
2017-12-06 17:21 UTC, Bastien Nocera
committed Details | Review
lib: Remove functions deprecated since 3.10 (3.84 KB, patch)
2017-12-06 17:21 UTC, Bastien Nocera
committed Details | Review
lib: Remove deprecated GWeatherForecastType (2.88 KB, patch)
2017-12-06 17:22 UTC, Bastien Nocera
committed Details | Review
data: Update README.sources (1.15 KB, patch)
2017-12-06 17:26 UTC, Bastien Nocera
committed Details | Review
build: Bump soname for API changes (1018 bytes, patch)
2017-12-07 00:24 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2017-12-06 17:21:33 UTC
.
Comment 1 Bastien Nocera 2017-12-06 17:21:38 UTC
Created attachment 365124 [details] [review]
data: Update README.timezones for current UI

No need to mention applets, or intlclock, the most current UI is
GNOME Clocks.
Comment 2 Bastien Nocera 2017-12-06 17:21:46 UTC
Created attachment 365125 [details] [review]
data: Remove check-timezones.sh

The code is quite clunky and a similar test already exists in
test_libgweather.
Comment 3 Bastien Nocera 2017-12-06 17:21:53 UTC
Created attachment 365126 [details] [review]
lib: Remove functions deprecated since 3.10

Those functions have been deprecated for 4 years, remove them now.
Comment 4 Bastien Nocera 2017-12-06 17:22:00 UTC
Created attachment 365127 [details] [review]
lib: Remove deprecated GWeatherForecastType

And its use in gweather_info_new().
Comment 5 Bastien Nocera 2017-12-06 17:26:57 UTC
Created attachment 365128 [details] [review]
data: Update README.sources

s/subversion/git/
Comment 6 Giovanni Campagna 2017-12-06 21:26:05 UTC
As gnome weather maintainer I don't mind because the ABI change does not matter to JS, but are the Clocks and EDS people ok with the soname bump?
Comment 7 Bastien Nocera 2017-12-07 00:21:18 UTC
(In reply to Giovanni Campagna from comment #6)
> As gnome weather maintainer I don't mind because the ABI change does not
> matter to JS, but are the Clocks and EDS people ok with the soname bump?

Clocks didn't require any changes, EDS changes are in bug 791327.

I'll bump soname and push all this.
Comment 8 Bastien Nocera 2017-12-07 00:24:10 UTC
Created attachment 365169 [details] [review]
build: Bump soname for API changes

One function changed signature (commit 80bff9e), 2 functions got removed
(commit c519c90).
Comment 9 Bastien Nocera 2017-12-07 00:28:57 UTC
Attachment 365124 [details] pushed as bbf01f2 - data: Update README.timezones for current UI
Attachment 365125 [details] pushed as b5fcc84 - data: Remove check-timezones.sh
Attachment 365126 [details] pushed as ac2a307 - lib: Remove functions deprecated since 3.10
Attachment 365127 [details] pushed as 7e9d27c - lib: Remove deprecated GWeatherForecastType
Attachment 365128 [details] pushed as 168a58f - data: Update README.sources
Attachment 365169 [details] pushed as 659e9c9 - build: Bump soname for API changes