After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791312 - Find dialog should reverse-search on enter.
Find dialog should reverse-search on enter.
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-06 16:57 UTC by Kevin Cox
Modified: 2017-12-17 21:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix (1.91 KB, patch)
2017-12-17 18:29 UTC, Egmont Koblinger
committed Details | Review

Description Kevin Cox 2017-12-06 16:57:56 UTC
Some time ago the find dialog changed from doing a reverse search by default to doing a forward search. This is not very useful as it will search though old commands before the most recent. It would be good to return this behaviour to the previous mode.

Reproduction.

1. Open gnome-terminal
2. Run: yes | head
3. Open find dialog (Shortcut: <C-f>)
4. Type "y" then press Enter

Expected behaviour: The most recent "y" was highlighted.

Actual behaviour: The first "y" was highlighted.

This is especially annoying with unlimited scrollback as the UI completely freezes until it has finished loading my scrollback and searching through it. Then I have to use the mouse to click the "Search for previous occurrence" button to find a recent result.
Comment 1 Egmont Koblinger 2017-12-17 18:29:08 UTC
Created attachment 365661 [details] [review]
Fix
Comment 2 Christian Persch 2017-12-17 18:38:40 UTC
Comment on attachment 365661 [details] [review]
Fix

Thanks!
Comment 3 Egmont Koblinger 2017-12-17 21:01:01 UTC
Fixed.
Comment 4 Kevin Cox 2017-12-17 21:38:25 UTC
Thanks!
Comment 5 Egmont Koblinger 2017-12-17 21:40:11 UTC
You're welcome! :)