After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791308 - Named timezones fixes
Named timezones fixes
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-12-06 14:20 UTC by Bastien Nocera
Modified: 2017-12-06 14:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
search-provider: Allow searching for named timezones (1.30 KB, patch)
2017-12-06 14:20 UTC, Bastien Nocera 		committed Details | Review
world: Fix named timezones appearing with no name (1.04 KB, patch)
2017-12-06 14:20 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2017-12-06 14:20:50 UTC 
This fixes named timezones having no name in the main UI, and not appearing
in the search provider.
Comment 1 Bastien Nocera 2017-12-06 14:20:54 UTC 
Created attachment 365117 [details] [review]
search-provider: Allow searching for named timezones

We don't want to restrict the search to just cities, as we want named
timezones to also appear in the list.

See https://bugzilla.gnome.org/show_bug.cgi?id=692243
Comment 2 Bastien Nocera 2017-12-06 14:20:59 UTC 
Created attachment 365118 [details] [review]
world: Fix named timezones appearing with no name

Named timezones don't have city names, as they're not cities. Fall back
to the timezone name in that case.

See https://bugzilla.gnome.org/show_bug.cgi?id=692243
Comment 3 Paolo Borelli 2017-12-06 14:22:46 UTC 
Review of attachment 365117 [details] [review]:

Great
Comment 4 Paolo Borelli 2017-12-06 14:23:31 UTC 
Review of attachment 365118 [details] [review]:

Looks good
Comment 5 Bastien Nocera 2017-12-06 14:24:01 UTC 
Attachment 365117 [details] pushed as ba06ecb - search-provider: Allow searching for named timezones
Attachment 365118 [details] pushed as 9a35675 - world: Fix named timezones appearing with no name