After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791273 - Explicitly specify the Gepub API version that should be imported
Explicitly specify the Gepub API version that should be imported
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-12-05 16:36 UTC by Debarshi Ray
Modified: 2017-12-26 19:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main: Explicitly specify the Gepub API version (940 bytes, patch)
2017-12-05 16:43 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-12-05 16:36:43 UTC 
Having the API version explicitly specified helps when one has multiple Gepub APIs installed parallely to work on older branches. For example, I am currently working on some RHEL 7 bugs and the branch I am working on, gnome-3-22, needs Gepub 0.4, while newer branches require 0.5. So, I have both 0.4 and 0.5 installed in parallel, which leads to:

  Gjs-Message: JS WARNING: [resource:///org/gnome/Documents/js/epubview.js 23]:
    Requiring Gepub but it has 2 versions available; use imports.gi.versions
    to pick one

(gnome-3-22 isn't *that* old, and since this is a young library, API bumps are to be expected.)
Comment 1 Debarshi Ray 2017-12-05 16:43:47 UTC 
Created attachment 365037 [details] [review]
main: Explicitly specify the Gepub API version
Comment 2 Cosimo Cecchi 2017-12-05 21:49:32 UTC 
Review of attachment 365037 [details] [review]:

LGTM
Comment 3 Debarshi Ray 2017-12-06 07:49:09 UTC 
Comment on attachment 365037 [details] [review]
main: Explicitly specify the Gepub API version

Pushed to master.
Comment 4 Iñigo Martínez 2017-12-26 19:16:13 UTC 
I must say that this works in my computer, but wouldn't it be necessary to check if the libgepub ('>= 0.5') exists in the system when using either autotools or meson? (or at least in GIR generation).