Bug 791196 – alsamidisrc: unlock create function on shutdown

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 791196 - alsamidisrc: unlock create function on shutdown


Summary:	alsamidisrc: unlock create function on shutdown


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-plugins-base
Version:	git master
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	1.13.1
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2017-12-04 09:54 UTC by Tim-Philipp Müller
Modified:	2017-12-08 10:42 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
alsamidisrc: unlock create function on shutdown (4.81 KB, patch) 2017-12-04 09:54 UTC, Tim-Philipp Müller	none	Details \| Review

Description Tim-Philipp Müller 2017-12-04 09:54:27 UTC

Created attachment 364894 [details] [review]
alsamidisrc: unlock create function on shutdown

Fixes occasional hang in generic/states unit test or
    
  GST_CHECKS=test_state_changes_up_and_down_seq make forever

---

This fixes the hang for me and seems correct, but I don't know if it still works in normal operation.

Could someone please test?

Comment 1 Antonio Ospite 2017-12-08 10:19:03 UTC

JFTR the alsa sequencer, and hence alsamidisrc, can be tested also with virtual midi devices, for example executing "vkeybd" (which should use port 128:0 if there are no other sequencer clients) and then using a pipeline like the one below:

  GST_PLUGIN_PATH=/home/ao2/WIP/gstreamer/gst-plugins-base/build/ext/alsa/ \
  GST_DEBUG=fluiddec:6 \
  gst-launch-1.0 alsamidisrc ports=128:0 ! fluiddec ! audioconvert ! autoaudiosink

The fluiddec debug output nicely shows the silent tick messages.

So I tested the patch with this set up, and also with a physical midi device (even though it makes no difference from the alsa point of view), and the patch does not seem to affect normal operation.

Thanks,
   Antonio

Comment 2 Tim-Philipp Müller 2017-12-08 10:42:21 UTC

Thanks for the info, and for testing! Pushed then:

commit 0ef44cefc9d4b8d188450a6daacbc9fa343961ea
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Mon Dec 4 09:49:35 2017 +0000

    alsamidisrc: unlock create function on shutdown
    
    Fixes occasional hang in generic/states unit test or
    
    GST_CHECKS=test_state_changes_up_and_down_seq make forever