After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791176 - GtkFileChooser: gtk4 defaults local_only to FALSE so docs need to be updated
GtkFileChooser: gtk4 defaults local_only to FALSE so docs need to be updated
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
3.92.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-12-03 19:37 UTC by Jeremy Bicha
Modified: 2017-12-14 15:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
FileChooser: Update set_local_only() doc’s default (1.39 KB, patch)
2017-12-04 15:12 UTC, Daniel Boles 		committed Details | Review

Description Jeremy Bicha 2017-12-03 19:37:28 UTC 
In gtk3, the file chooser did not show remote locations by default, but required app developers to opt in if they wanted that. It's the opposite in gtk4 so the docs need to be updated for that change.

https://git.gnome.org/browse/gtk+/commit/?id=5b3b111

https://developer.gnome.org/gtk4/stable/GtkFileChooser.html#gtk-file-chooser-set-local-only
Comment 1 Daniel Boles 2017-12-04 15:12:08 UTC 
Created attachment 364920 [details] [review]
FileChooser: Update set_local_only() doc’s default
Comment 2 Jeremy Bicha 2017-12-04 15:49:33 UTC 
Comment on attachment 364920 [details] [review]
FileChooser: Update set_local_only() doc’s default

Thanks Daniel. I think it might help to say something like "the default since gtk 3.90 is %FALSE"
Comment 3 Matthias Clasen 2017-12-07 23:56:47 UTC 
Review of attachment 364920 [details] [review]:

ok
Comment 4 Daniel Boles 2017-12-08 09:58:37 UTC 
Thanks. Before I push, any opinion on whether to mention the version as Jeremy suggested?
Comment 5 Matthias Clasen 2017-12-08 23:24:26 UTC 
I think it is not necessary