After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791165 - Document settings allow to select "tabs" and "spaces"
Document settings allow to select "tabs" and "spaces"
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: preferences
Flatpak Nightly Channel
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-03 12:25 UTC by elias
Modified: 2017-12-13 23:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of "tabs" and "spaces" selected (26.77 KB, image/png)
2017-12-03 12:25 UTC, elias 		  Details
Patch that adds a binding in the .ui file (1.18 KB, patch)
2017-12-13 20:09 UTC, elias 		committed Details | Review

Description elias 2017-12-03 12:25:22 UTC 
Created attachment 364853 [details]
Screenshot of "tabs" and "spaces" selected

The indentation options in the document settings are not exclusive. This allows you to select both tabs AND spaces. It is also possible to select neither of them.
Comment 1 Christian Hergert 2017-12-05 02:15:43 UTC 
Some tricky code is involved here, in translating GSettings into actions w/ toggle buttons.

Code is in:

 src/libide/editor/ide-editor-properties.{c,h,ui}

Which is binding properties from the ide-source-view.{c,h}
Comment 2 elias 2017-12-13 20:09:18 UTC 
Created attachment 365508 [details] [review]
Patch that adds a binding in the .ui file
Comment 3 Christian Hergert 2017-12-13 23:28:23 UTC 
Thanks! Quick test shows it seems to do what is expected.