After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791094 - build: Explicitly enable C99 support
build: Explicitly enable C99 support
Status: RESOLVED FIXED
Product: msitools
Classification: Other
Component: gcab
unspecified
Other All
: Normal normal
: 1.0
Assigned To: msitools maintainer(s)
msitools maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-12-01 17:16 UTC by Philip Withnall
Modified: 2017-12-03 20:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Explicitly enable C99 support (895 bytes, patch)
2017-12-01 17:16 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2017-12-01 17:16:01 UTC 
Trivial patch attached. This is breaking Coverity scans for anything which depends on gcab.
Comment 1 Philip Withnall 2017-12-01 17:16:05 UTC 
Created attachment 364771 [details] [review]
build: Explicitly enable C99 support

We use C99 declarations in loops in gcab-cabinet.c. For the benefit of
older compilers (Debian Jessie, I’m looking at you), explicitly enable
C99 support.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Marc-Andre Lureau 2017-12-01 17:25:24 UTC 
Review of attachment 364771 [details] [review]:

ack
Comment 3 Philip Withnall 2017-12-03 20:00:38 UTC 
Attachment 364771 [details] pushed as b957282 - build: Explicitly enable C99 support