After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791091 - videodecoder: Only drain if the internal queue is not empty
videodecoder: Only drain if the internal queue is not empty
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.13.x
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-01 15:05 UTC by Nicolas Dufresne (ndufresne)
Modified: 2018-11-03 12:01 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Nicolas Dufresne (ndufresne) 2017-12-01 15:05:03 UTC
Right now we drain, and drain, and then start playback. This makes very little sense, since nothing has ever been queued into the decoder yet. On seeks we do finish(), flush(), drain(). We are basically over telling the decoder to drain() here, because after finish() + flush() the decoder should be pretty drained already.

I didn't yet had time to write the patch, seems mostly trivial, but what I'm suggesting is to read the queue size before sending a drain. This we we don't have to do this check in every subclass. Some decoder don't really do this check, and the most common side effect is a slow start (specially for hardware decoders).
Comment 1 GStreamer system administrator 2018-11-03 12:01:59 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/404.