GNOME Bugzilla – Bug 791084
Remove Yahoo! Weather support
Last modified: 2017-12-01 21:00:00 UTC
.
Created attachment 364754 [details] [review] Remove Yahoo! Weather support The RSS feed URL was moved from: https://weather.yahooapis.com/forecastrss to: https://weather-ydn-yql.media.yahoo.com/forecastrss as per https://developer.yahoo.com/weather/documentation.html But this new location requires use of OAuth to link the API to the application. Given that we relied on the URL to be freely accessible, and that we have so few locations with a Yahoo "Where On Earth" ID set, we might as well remove the code to avoid failing to fetch the weather for those locations.
Created attachment 364756 [details] [review] Remove Yahoo! Weather support The RSS feed URL was moved from: https://weather.yahooapis.com/forecastrss to: https://weather-ydn-yql.media.yahoo.com/forecastrss as per https://developer.yahoo.com/weather/documentation.html But this new location requires use of OAuth to link the API to the application. Given that we relied on the URL to be freely accessible, and that we have so few locations with a Yahoo "Where On Earth" ID set, we might as well remove the code to avoid failing to fetch the weather for those locations.
Review of attachment 364754 [details] [review]: I agree with the removal. ::: libgweather/gweather-weather.h @@ +45,3 @@ GWEATHER_PROVIDER_YR_NO = 1 << 4, GWEATHER_PROVIDER_OWM = 1 << 5, + GWEATHER_PROVIDER_ALL = b11011 I think you should leave this enum unchanged, to keep ABI compatibility. We won't reuse 1 << 3 anyway, and the code does not check for unknown flags.
Created attachment 364769 [details] [review] Remove Yahoo! Weather support The RSS feed URL was moved from: https://weather.yahooapis.com/forecastrss to: https://weather-ydn-yql.media.yahoo.com/forecastrss as per https://developer.yahoo.com/weather/documentation.html But this new location requires use of OAuth to link the API to the application. Given that we relied on the URL to be freely accessible, and that we have so few locations with a Yahoo "Where On Earth" ID set, we might as well remove the code to avoid failing to fetch the weather for those locations.
Created attachment 364770 [details] [review] Remove Yahoo! Weather support The RSS feed URL was moved from: https://weather.yahooapis.com/forecastrss to: https://weather-ydn-yql.media.yahoo.com/forecastrss as per https://developer.yahoo.com/weather/documentation.html But this new location requires use of OAuth to link the API to the application. Given that we relied on the URL to be freely accessible, and that we have so few locations with a Yahoo "Where On Earth" ID set, we might as well remove the code to avoid failing to fetch the weather for those locations.
Attachment 364770 [details] pushed as dfc8744 - Remove Yahoo! Weather support
I also made a mention of the removal of the Yahoo backend in the enum above.