After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791069 - log failing OMX calls as errors
log failing OMX calls as errors
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-01 11:56 UTC by Guillaume Desmottes
Modified: 2018-01-29 17:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
log failing OMX calls as errors (7.96 KB, patch)
2017-12-01 11:56 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2017-12-01 11:56:23 UTC 
.
Comment 1 Guillaume Desmottes 2017-12-01 11:56:40 UTC 
Created attachment 364743 [details] [review]
log failing OMX calls as errors

I find it confusing when debugging that OMX calls returning an error
where not logged as GST_LEVEL_ERROR making them harder to spot.
Fix this by introducing simple log macros checking the return value of
the OMX call and logging failures as errors.
Comment 2 Nicolas Dufresne (ndufresne) 2018-01-29 17:21:40 UTC 
Review of attachment 364743 [details] [review]:

Ok, it's will be possibly spammy in some corder cases, but I think it's generally useful, so let's pay the cost of having to fix the spammy cases later.
Comment 3 Nicolas Dufresne (ndufresne) 2018-01-29 17:48:11 UTC 
Attachment 364743 [details] pushed as 0f702d0 - log failing OMX calls as errors