After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791067 - tracker-monitor: The GType of the monitor backend isn't used instance-wide
tracker-monitor: The GType of the monitor backend isn't used instance-wide
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Miners
git master
Other All
: Normal normal
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2017-12-01 11:06 UTC by Debarshi Ray
Modified: 2018-01-16 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tracker-monitor: Tighten the scope of variables (1.72 KB, patch)
2017-12-01 11:07 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-12-01 11:06:26 UTC 
This is a micro-optimization that I spotted while reading the code. The monitor_backend GType doesn't have to be an instance variable.
Comment 1 Debarshi Ray 2017-12-01 11:07:40 UTC 
Created attachment 364739 [details] [review]
tracker-monitor: Tighten the scope of variables
Comment 2 Carlos Garnacho 2018-01-16 11:31:22 UTC 
Comment on attachment 364739 [details] [review]
tracker-monitor: Tighten the scope of variables

well spotted :).
Comment 3 Debarshi Ray 2018-01-16 12:56:47 UTC 
Comment on attachment 364739 [details] [review]
tracker-monitor: Tighten the scope of variables

Pushed to master, thanks!