After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791052 - Missing dependency on pthread
Missing dependency on pthread
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-01 02:05 UTC by Emmanuele Bassi (:ebassi)
Modified: 2017-12-01 16:38 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Emmanuele Bassi (:ebassi) 2017-12-01 02:05:53 UTC
The terminal server calls pthread_atfork(), but the GNOME Terminal build does not explicitly depend on pthreads. The reason why it works is because there's a transitive implicit dependency coming from GLib — but GLib may not necessarily build with pthreads or exposes this dependency explicitly in any way. I only caught this because the pkg-config file for GLib temporarily lost the pthread variables in the Meson build.

Ideally, GNOME Terminal should use the AX_PTHREADS m4 macro to check for pthread, and add PTHREADS_CFLAGS and PTHREADS_LIBS to the terminal server target, since it's using pthread API directly, instead of GLib wrappers.