After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791025 - GdTaggedEntry has theming problems
GdTaggedEntry has theming problems
Status: RESOLVED NOTABUG
Product: libgd
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgd maintainer(s)
libgd maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-11-30 14:05 UTC by Adrien Plazas
Modified: 2017-12-01 12:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Broken style with a different theme (87.79 KB, image/png)
2017-11-30 14:07 UTC, Adrien Plazas
Details

Description Adrien Plazas 2017-11-30 14:05:30 UTC
The GdTaggedEntry used for search and Documents and Books don't show the same blue and spacing as in Music and Nautilus. They also are broken with other themes.

As libgd is developed alongside Documents I don't know if Documents is faulty or if the other applications and the theme are, but a uniformization across the different GNOME apps would be welcome.
Comment 1 Adrien Plazas 2017-11-30 14:07:25 UTC
Created attachment 364680 [details]
Broken style with a different theme
Comment 2 Debarshi Ray 2017-11-30 14:25:15 UTC
These days GdTaggedEntryTag is styled by the entry-tag style class from Adwaita. See:

commit cc90107531640bcba6c3c58e5cf6aec94d498763
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Fri Apr 7 18:34:08 2017 +0200

    tagged-entry: Use the entry-tag CSS style class from Adwaita
    
    The dark and light variants of the CSS for GdTaggedEntryTag were still
    scattered across applications and libgd as the photos-entry-tag and
    documents-entry-tag style classes. It has been decided to consolidate
    all that in Adwaita, like we do for the other libgd style classes, as
    the "entry-tag" style class.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=781671

For some time before that, libgd had a documents-entry-tag style class, which was used by the light themed applications (eg., gnome-documents), while the dark themed applications (eg., gnome-photos) replaced it with a different style class and their own custom CSS.

And before that, the documents-entry-tag CSS lived in gnome-documents.

I think the problem is caused by Music and Nautilus still carrying their own custom CSS, and the theme in question not having the entry-tag class. I'd suggest that Music, Nautilus and any other app just use the default entry-tag class, and requiring themes to provide the CSS for it.

> As libgd is developed alongside Documents

It's developed alongside whichever application happens to use it. :)
Comment 3 Debarshi Ray 2017-11-30 15:07:20 UTC
I filed https://gitlab.gnome.org/GNOME/nautilus/issues/147 for nautilus.
Comment 4 Debarshi Ray 2017-11-30 15:55:53 UTC
Closing as NOTABUG after talking to Adrien in #documents on GIMPNet. It's not a bug in libgd but something to fix in the applications by deleting the custom CSS.
Comment 5 Adrien Plazas 2017-12-01 12:39:11 UTC
For reference, I filled https://bugzilla.gnome.org/show_bug.cgi?id=791077 for Music.