After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791018 - Stale build artifacts included in make-dist tarball
Stale build artifacts included in make-dist tarball
Status: RESOLVED OBSOLETE
Product: libgee
Classification: Platform
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: libgee-maint
libgee-maint
Depends on:
Blocks:
 
 
Reported: 2017-11-30 11:10 UTC by bob
Modified: 2019-03-20 10:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-autotools-fix-up-make-dist-rules.patch (5.21 KB, patch)
2017-11-30 12:30 UTC, bob 		none Details | Review

Description bob 2017-11-30 11:10:24 UTC 
The tarballs produced by `make dist` may contain C/VAPI files that haven't been generated from the Vala sources currently in the source tree. This issue affects at least the 0.20 tarball available from download.gnome.org which currently contains outdated sources (potentially several older versions are affected, since the generated files appear to be fairly old).

Subsequently, distros building packages with tarballs obtained from download.gnome.org will produce binaries from substantially outdated sources.
Comment 1 bob 2017-11-30 12:30:13 UTC 
Created attachment 364665 [details] [review]
0001-autotools-fix-up-make-dist-rules.patch

After a brief discussion in the #vala IRC, it appears that support for valac-less compilation is no longer necessary. This patch removes support for this build configuration and adds valac-generated sources into the various nodist lists (fixing this bug as a side-effect).
Comment 2 Rico Tzschichholz 2017-12-11 12:58:56 UTC 
The tarball is meant to ship pre-generated c-sources. The problem is that tarball wasn't created properly from a clean source-tree.
Comment 3 GNOME Infrastructure Team 2019-03-20 10:41:38 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libgee/issues/26.