GNOME Bugzilla – Bug 791017
Small warning fixes
Last modified: 2017-11-30 14:30:39 UTC
Trivial patches attached, although the rsvg-styles patch should be reviewed carefully to make sure the changes conform to the SVG spec (I am just guessing at what the code is supposed to do).
Created attachment 364658 [details] [review] rsvg-filter: Use fabs() instead of abs() for floats Fixes a compiler warning (-Wabsolute-value). Signed-off-by: Philip Withnall <withnall@endlessm.com>
Created attachment 364659 [details] [review] rsvg-styles: Fix badly structured comparisons It looks like someone ported from g_strcmp0() to g_str_equal() at some point and forgot to remove the return value comparison, leaving two comparisons against the g_str_equal() return value in the condition. Drop one of the comparisons, hoping it’s the right one based on the context. Spotted with -Wlogical-not-parentheses. Signed-off-by: Philip Withnall <withnall@endlessm.com>
Review of attachment 364658 [details] [review]: Please commit this!
Review of attachment 364659 [details] [review]: Good catch! Please commit this. For extra points, could you fix the indentation of the line that contains xml:space? It's within the lines you touched.
I’ve fixed the indentation problem as a separate follow-up commit (pushed without review). Thanks for the fast reviews! Attachment 364658 [details] pushed as 2898220 - rsvg-filter: Use fabs() instead of abs() for floats Attachment 364659 [details] pushed as ac59670 - rsvg-styles: Fix badly structured comparisons