After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791007 - Adjust meson options to match best practices
Adjust meson options to match best practices
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-11-29 23:24 UTC by Florian Müllner
Modified: 2017-11-30 12:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Remove 'enable' prefix from option names (2.67 KB, patch)
2017-11-29 23:24 UTC, Florian Müllner
committed Details | Review
build: Stop detecting features automatically (2.76 KB, patch)
2017-11-29 23:25 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2017-11-29 23:24:51 UTC
See patches and https://wiki.gnome.org/Initiatives/GnomeGoals/MesonPorting.
Comment 1 Florian Müllner 2017-11-29 23:24:56 UTC
Created attachment 364643 [details] [review]
build: Remove 'enable' prefix from option names

Meson options are typed, so the prefix isn't necessary, and indeed
looks odd when used to disable the option:
 -Denable_foo=false

Also replace underscores with dashes, which is the preferred meson
style.
Comment 2 Florian Müllner 2017-11-29 23:25:03 UTC
Created attachment 364644 [details] [review]
build: Stop detecting features automatically

Auto-detect options add some convenience for platforms where a
particular feature isn't available - systemd on non-Linux OS comes
to mind - but the downside is that it is easy to accidentally build
without a desired feature. We consider the latter much more serious
nowadays, so turn our auto-detect options into regular boolean
options.
Comment 3 Jonas Ådahl 2017-11-30 07:52:46 UTC
Review of attachment 364643 [details] [review]:

lgtm
Comment 4 Jonas Ådahl 2017-11-30 07:52:55 UTC
Review of attachment 364644 [details] [review]:

lgtm
Comment 5 Florian Müllner 2017-11-30 12:31:14 UTC
Attachment 364643 [details] pushed as 10c602f - build: Remove 'enable' prefix from option names
Attachment 364644 [details] pushed as ca367e4 - build: Stop detecting features automatically