After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790992 - Add hunspell sysdep + enchant-2 module, will be needed by gspell
Add hunspell sysdep + enchant-2 module, will be needed by gspell
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2017-11-29 16:41 UTC by Sébastien Wilmet
Modified: 2017-11-29 17:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sysdeps-3.28: add hunspell (889 bytes, patch)
2017-11-29 16:42 UTC, Sébastien Wilmet
committed Details | Review
core-deps-3.28: add enchant-2 (2.17 KB, patch)
2017-11-29 16:42 UTC, Sébastien Wilmet
committed Details | Review

Description Sébastien Wilmet 2017-11-29 16:41:11 UTC
I'll attach two patches.
Comment 1 Sébastien Wilmet 2017-11-29 16:42:36 UTC
Created attachment 364628 [details] [review]
sysdeps-3.28: add hunspell

This will be needed by enchant-2.
Comment 2 Sébastien Wilmet 2017-11-29 16:42:41 UTC
Created attachment 364629 [details] [review]
core-deps-3.28: add enchant-2

gspell will depend on it, and Enchant 2 is not yet packaged in all
distros, so it cannot be a sysdep like for Enchant 1. In the future when
all major distros will ship Enchant 2, then I think enchant-2 can become
a sysdep in the jhbuild moduleset.

--with-hunspell-dir is required because otherwise Enchant doesn't find
the hunspell dictionaries.

The hunspell backend is preferred, aspell can be considered deprecated.
gspell doesn't work well with aspell (some unit tests fail). When both
hunspell and aspell are installed, Enchant prefers hunspell by default.
I think all major distros use hunspell by default, see those old
projects:
https://fedoraproject.org/wiki/Releases/FeatureDictionary
https://wiki.ubuntu.com/ConsolidateSpellingLibs
Comment 3 Michael Catanzaro 2017-11-29 16:44:40 UTC
These should be committed at the same time that gspell is changed to depend on them.
Comment 4 Sébastien Wilmet 2017-11-29 17:13:02 UTC
Done. Thanks for the quick reply.

Attachment 364628 [details] pushed as dfe282e - sysdeps-3.28: add hunspell
Attachment 364629 [details] pushed as 30f1214 - core-deps-3.28: add enchant-2